Fix black window switching from music to video, #4055 #4249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will: - Effectively revert the changes made in commit f8811b6 that attempted to always draw using the mpvGLQueue queue - Add an Atomic property wrapper to protect a property with a lock - Add locking to the VideoLayer properties blocked, forceRender and needsMPVRender The commit f8811b6 attempted to standardize drawing to always use the mpvGLQueue queue to resolve TSan detected data races reported in issue #3827 without using locks. However as discussed in issue #4055 drawing can still occur on the main thread. This commit resolves the TSan data races using locks.
1 task
1 task
|
Pulled and tested, confirmed the issue has been fixed. |
uiryuu
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will:
The commit f8811b6 attempted to standardize drawing to always use the mpvGLQueue queue to resolve TSan detected data races reported in issue #3827 without using locks. However as discussed in issue #4055 drawing can still occur on the main thread. This commit resolves the TSan data races using locks.
Description: