Close support subtitle visibility, #4235 #4237
Conversation
|
See the issue for a screen shot of what the Missing is integration with the plugin API. Should this be exposed to plugins? |
|
Instead of "Subtitle Visibility: On/Off", how about "Subtitles Visible" / "Subtitles Hidden"? |
|
I think I was too focused on making the new OSD messages follow the patterns in the existing messages. I've updated the PR to use the suggested messages. I added screen shots of the new messages to the issue. The other thing that is missing from the PR is support for the visibility feature in the |
|
I converted this to a draft as I am working on adding support to the |
|
The latest changes rebase with This proposed implementation is in response to the issue #4235 which originated out of issue #4234. I missed that this has come up in the past in issue #2856 with a draft PR #3053. There was even discussion of the problem the mpv feature causes for people that accidentally trigger it. @WowbaggersLiquidLunch, @unique-username313, the current proposed changes are not as expansive as had been proposed in the past. This PR just provides a GUI for the mpv feature. Critical review comments are welcome. |
|
Rebased with |
This commit will: - Add a Hide Subtitles/Show Subtitles item to the Subtitles menu - Add a Hide Second Subtitles/Show Second Subtitles item to the Subtitles menu - Add a key binding mapping v to cycle sub-visibility - Add a key binding mapping Alt-v to cycle secondary-sub-visibility - Add a new OSD message Subtitle Visibility: On/Off - Add a new OSD message Second Subtitle Visibility: On/Off - Add secondary-sub-visibility to watch-later-options - Add logging of watch-later-options These changes add a graphical user interface for the mpv features that control subtitle visibility.
This commit will: - Add a Hide Subtitles/Show Subtitles item to the Subtitles menu - Add a Hide Second Subtitles/Show Second Subtitles item to the Subtitles menu - Add a key binding mapping v to cycle sub-visibility - Add a key binding mapping Alt-v to cycle secondary-sub-visibility - Add a new OSD messages Subtitles Hidden/Visible - Add a new OSD messages Second Subtitles Hidden/Visible - Add secondary-sub-visibility to watch-later-options - Add logging of watch-later-options These changes add a graphical user interface for the mpv features that control subtitle visibility.
This commit will: - Add a Hide Subtitles/Show Subtitles item to the Subtitles menu - Add a Hide Second Subtitles/Show Second Subtitles item to the Subtitles menu - Add buttons for controlling visibility of subtitles to the SUBTITLES tab of the Quick Settings Panel - Add a key binding mapping v to cycle sub-visibility - Add a key binding mapping Alt-v to cycle secondary-sub-visibility - Add a new OSD messages Subtitles Hidden and Subtitles Visible - Add a new OSD messages Second Subtitles Hidden and Second Subtitles Visible - Add secondary-sub-visibility to watch-later-options - Add logging of watch-later-options These changes add a graphical user interface for the mpv features that control subtitle visibility.
This commit will:
These changes add a graphical user interface for the mpv features that control subtitle visibility.
Description: