Improve reliability of click detection in player window by adding minimum threshold for drag #4232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck that at least 2pts distance is moved in order to qualify as a drag instead of a click.
|
See my long comment in the issue. I'm thinking the user should be able to control this, but wait to see what others think. |
uiryuu
requested changes
Mar 29, 2023
iina/MainWindowController.swift
Outdated
| @@ -49,6 +49,8 @@ fileprivate extension NSStackView.VisibilityPriority { | |||
| static let detachEarliest = NSStackView.VisibilityPriority(rawValue: 750) | |||
| } | |||
|
|
|||
| // The minimum distance that the user must drag before their click or tap gesture is interpreted as a drag gesture: | |||
| fileprivate let minimumInitialDragDistance: CGFloat = 4.0 | |||
There was a problem hiding this comment.
Please add some comments to clarify that the intended distance is 2 instead of 4 since we are using spared distance.
…DragDistance to 3.0 pts.
|
Made another commit. The whole "squared" thing was due to copying an answer from StackOverflow, but it's silly to focus on avoiding a square root in this case because it won't affect performance in any meaningful way. Tweaked the drag distance so it is 3.0 pts instead of 4.0, but shouldn't make much difference. |
uiryuu
approved these changes
Mar 30, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This updates the click detection in
MainWindowControllerand adds a requirement that after mouseDown the user must drag the cursor at least 2pts distance for drag to start.A given
mouseDown/mouseUppair is processed as either a click or a drag, but not both. The out-of-the-box behavior in Cocoa is unfortunately not very useful to take on its own: themouseDraggedcallback is called with very high sensitivity (particularly with trackpad actions);mouseDraggedwill get called for drag distances of just a fraction of a pixel. This is both not very useful as a an actual drag distance, and actively harmful because it results in clicks/taps appearing to be ignored from the user's standpoint.After some testing and tweaking, I concluded that a drag start threshold requirement of 2pts is all that's needed to ensure that clicks are registered reliably and there is no noticeable burden on actual drag attempts. Note that 2pts is all that's needed to start the drag, so if the user's goal is to move their player window by only 1pt, they will have to first drag it by 2 pts to register the drag, then drag it back by 1 pt to position it. I believe this behavior is similar to how CAD & layout software usually works, but as a video player it's expected to be very rare that any user will be making such fine adjustments anyway.