Fix wrong title shown in window menu, #4229 #4230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
This commit will remove the check that suppressed the workaround in MainWindowController.windowWillOpen for the title problem when running under macOS 12+. The workaround was conditionalized because AppKit was confirmed to be working correctly under macOS 12.3. The assumption was that we could count of AppKit working correctly going forward. However the problem is back in macOS 13.2.1. Not clear when it was re-introduced. Rebased with develop and corrected merge conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will remove the check that suppressed the workaround in MainWindowController.windowWillOpen for the title problem when running under macOS 12+.
The workaround was conditionalized because AppKit was confirmed to be working correctly under macOS 12.3. The assumption was that we could count of AppKit working correctly going forward. However the problem is back in macOS 13.2.1. Not clear when it was re-introduced.
Description: