Fix fullscreen only works for first video, #4202 #4226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will: - Remove a check in `PlayerCore.fileLoaded` that only put the player into full screen mode for the first file - Remove the property `justLaunched` from `PlaybackInfo` This causes the "Enter fullscreen" setting under the "When media is opened" settings to when enabled put the player into full screen mode for all videos, not just the first video played.
1 task
|
I think this should be a safe fix, based on the current code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will:
PlayerCore.fileLoadedthat only put the player into full screen mode for the first filejustLaunchedfromPlaybackInfoThis causes the "Enter fullscreen" setting under the "When media is opened" settings to when enabled put the player into full screen mode for all videos, not just the first video played.
Description: