Workaround cursor visible after button click, #4183 #4191
Conversation
|
I think it is possible that Apple intentionally did that. So what if we show the UI as well when pausing and resuming even if the cursor doesn't move? |
|
I would find the behavior of bringing up the OSC even though the mouse did not move irritating and would ask for a preference to disable it. Some of the time I intentionally keep the mouse still and pause and resume using the mouse buttons. I did not notice this defect since the Mac's I do that on are still running Catalina (which does not have this problem) as I wait for Apple to fix some of the many regressions added in Big Sur. Without adding new ones. I too was worried that Apple intentionally made this horrendous change breaking backward compatibility, turning the name of the API into a lie and then on top of that did not update the documentation to reflect this new unexpected behavior, all for something an application can easily accomplish if they want to while processing the button click. I concluded Apple can not have possibly intentionally made such a change and it must be an accidental regression. As of today Apple has not responded to the feedback I submitted reporting this regression. My guess is that during triage they looked at the title of my feedback and thought "that can't possibly be broken, must be a user error" and inserted my defect report deep into the massive backlog. |
|
I continued to think about this today. I'm now even more convinced that the correct solution is to restore the IINA behavior seen in Catalina before Apple changed AppKit. To get to the OSC all the user has to do is to move the mouse. But that is not what they are doing. They are intentionally clicking somewhere in the window instead of moving the mouse. They are doing this to invoke whatever action they have configured IINA to perform in reaction to a mouse button click. That can be configured in the IINA settings In my case I have the The user does receive feedback if they have the button click configured to |
This commit will: - Add a new method workaroundCursorDefect to MainWindowController that will hide the cursor again if the OSC is hidden - Change mouseDown and mouseUp to call workaroundCursorDefect - Add methods otherMouseDown, otherMouseUp, rightMouseDown and rightMouseUp to MainWindowController that apply the workaround - Add method rightMouseDown to VideoView to pass that mouse event to MainWindowController These changes workaround a regression in the macOS AppKit method NSCursor.setHiddenUntilMouseMoves introduced in macOS Big Sur that causes the cursor to become visible when a mouse button is clicked even if the mouse does not move. This problem has been reported to Apple.
This commit will:
These changes workaround a regression in the macOS AppKit method NSCursor.setHiddenUntilMouseMoves introduced in macOS Big Sur that causes the cursor to become visible when a mouse button is clicked even if the mouse does not move.
This problem has been reported to Apple.
Description:
This is a workaround for a macOS AppKit defect.