Allow OSD progress bar to scale for large text sizes #4187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
low-batt
approved these changes
Feb 21, 2023
|
It was probably intentional, but I think there's no reason to keep that fixed 150 point size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Was about to file a bug for this, but found that someone already filed this as an enhancement request.
Not sure why the progress bar was given this fixed width constraint; its width is already implicitly specified by virtue of being inside an
NSStackView, and if the intent was to allow widths only up to 150 points, it's not the most reliable way to do it. Probably it was an artifact of some earlier development which was forgotten about.