Fix layout errors & warnings in Quick Settings panels, fix clipping due to H scroll, optimize layout #4029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ways". Fix constraint errors, warnings and all other layout issues in Quick Settings panels. Merge Custom crop button into segmented control.
2 tasks
1 task
low-batt
approved these changes
Nov 6, 2022
|
This is what the panel looks like with this fix. The scroll bar no longer overlaps controls in the panel: |
|
I'd say I like this design. I understand to include custom... in the segment control is a bit weird, but if no better idea, we can ship this. |
uiryuu
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This update will:
Custom...crop button into the segmented control with the other crops (see the comments in the above issue)