Add an HDR killswitch in the preferences #4006
Conversation
Remake of CarterLi@0cae124 Ref: #3808
|
I've pulled this PR locally. I've disabled the new HDR preference. IINA is still enabling HDR for the file I'm testing with. Restarting IINA did not help. Investigating... |
There was a problem hiding this comment.
The new preferences button needs to be bound to the setting in user defaults as can be seen was done for the ICC button shown in the screen shot above. I already was going to ask the other developers how you get Xcode to make this binding. The usual ctrl-click method was not working for me. Anyway this is why the new setting is not working. To see this all you have to do is uncheck the button and restart. The HDR enabled button will be checked again since the value was not stored in user defaults due to the missing binding.
Remake of CarterLi/iina@0cae124 Ref: #3808 Add binding in XIB from new button to new preference in user defaults.
|
Took me hours to figure out how you directly bind to user defaults in the XIB. All the posts I found on the web provided instructions for binding using code, not directly in the XIB. I finally found the correct place to do this in Xcode. I tested and when the new preference was disabled IINA did not enable HDR for the HDR video I was testing with. |
|
@low-batt My bad completely forgetting adding the binding... |
Description:
Since this contains mostly xib changes, redo instead of cherrypicking.
Remake of CarterLi@0cae124