Skip to content

HDR: Observe MPVProperty.videoParams* directly to avoid possible ra… #4005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2022
Merged

HDR: Observe MPVProperty.videoParams* directly to avoid possible ra… #4005

merged 1 commit into from
Oct 20, 2022

Conversation

low-batt
Copy link
Contributor

This commit will change MPVController, adding observers for:

  • MPVProperty.videoParamsPrimaries
  • MPVProperty.videoParamsGamma

And re-evaluate whether HDR should be enabled upon changes to these properties.

Ref: #3806 (comment)

Description:

@low-batt low-batt linked an issue Oct 19, 2022 that may be closed by this pull request
Will M1 macbook air get iina HDR support anytime soon? #3806
Closed
@low-batt low-batt requested a review from uiryuu October 19, 2022 17:42
@uiryuu uiryuu requested a review from lhc70000 October 20, 2022 01:29
@lhc70000
Copy link
Member

LGTM, merging.

@lhc70000 lhc70000 merged commit f5026a6 into develop Oct 20, 2022
@lhc70000 lhc70000 deleted the fix-3806 branch October 20, 2022 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uiryuu uiryuu Awaiting requested review from uiryuu

@lhc70000 lhc70000 Awaiting requested review from lhc70000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Will M1 macbook air get iina HDR support anytime soon?
3 participants
@low-batt @lhc70000 @CarterLi