Need to run other/parse_doc.rb so that the generated mpv interface classes, MPVCommand, MPVOption.swift and MPVProperty.swift match the version of mpv.

Fixed in the pushed commit. Actually I did this, but git status didn't give me any changes, so I just moved on. What I didn't know is that the generated files are in the same folder asprase_doc.rb and those newly generated swift files are ignored by git... I'll change this behavior later, at least print something to tell the user to copy the files to the designated folder.

Based on the changes of mpv options and properties, I think we need to do some changes in our code to reflect some of their name changes, right?

Was FFmpeg built with --enable-libjxl?

Yes it was. Weird, I'll do some investigation.

Yes, we need to make some changes in IINA as mpv renamed some of the properties/options we are using. IINA won't build with the updated generated files. I listed a couple of the changes needed above. These changes were in the list of changes mpv publishes. But video-format and video-codec and audio-codec have disappeared. They are used for the Inspector window. I've not been able to find out what happened to them.

And yes, the behavior of the generator script is confusing. I guess there was a concern about possibly stepping on some local changes? Otherwise it probably should put the files in their proper place.

The FFmpeg build missing --enable-libjxl was my best guess on what the FFmpeg error was about. I will have to look closer into that one if we have built FFmpeg with libjxl support.

Another thing I forgot. We have a lot of dangling references in the Xcode project to header files that have been removed. We should clean those up as well.

This is the mpv commit that removed properties like video-codec: mpv-player/mpv@e720159

This mpv commit removed the restriction on using current-tracks: mpv-player/mpv@e16d0dd

To fix the compilation errors in the Inspector code we first need to remove this code in parse_doc.rb:

  if name.include? 'current-tracks'
    # According to the mpv documentation this property is not supposed to be
    # used programmatically. We still output a comment for the property so
    # people can figure out why the Swift constant is missing.
    file.write "  /** #{name}  As per mpv docs, scripts etc. should not use this. */\n"

That restriction has been removed. We need to use that property because these properties that we were using have been removed from the documentation as mpv would prefer clients use the actual properties instead of these aliases:

M_PROPERTY_ALIAS("audio-codec", "current-tracks/audio/codec-desc"),
M_PROPERTY_ALIAS("video-format", "current-tracks/video/codec"),
M_PROPERTY_ALIAS("video-codec", "current-tracks/video/codec-desc"),

Updated parse_doc.rb and fixed build errors.

Reviewed latest changes. Built and runs without errors for me.

There are lots of dangling references under deps/include in the Xcode project. Since we are updating the includes we might as well fix that as well in this PR.

Do you want me to take care of that?

There are lots of dangling references under deps/include in the Xcode project.

Are you talking about we have unused headers from mpv and FFmpeg? Even if we have some headers that are not explicitly used in our code, specifically iina-Bridging-Header.h, they are cross-referenced. If we only keep the headers we used, the compiler will not find other headers which are referenced. I, too, have considered to keep minimum header files, but in order to do that we have to resolve the dependency tree and see which headers are not referenced in anywhere. And we need to do that every time after we update the headers, so I just poured every header files from mpv and FFmpeg and called it a day. Is this what you want to do?

Not that. It is that the Xcode project has references to headers that do not exist. Open up the group for libavutil in Xcode and you will see Xcode shows many in red, as in it can't find the file. At least that is what I'm seeing.

Sorry but I'm not seeing it on this bump-mpv branch. Can you provide a screenshot of missing headers?

Most of those files are missing for me:

low-batt@gag libavutil (bump-mpv $%=)$ ls -la
total 680
drwxr-xr-x  25 low-batt  staff    800 Jun 17 21:01 .
drwxr-xr-x   8 low-batt  staff    256 Apr 20  2023 ..
-rw-r--r--   1 low-batt  staff    336 Aug 18  2023 .gitignore
-rw-r--r--   1 low-batt  staff   4850 Aug 18  2023 attributes.h
-rw-r--r--@  1 low-batt  staff    180 Sep 22  2022 avconfig.h
-rw-r--r--   1 low-batt  staff   9495 Jun 17 21:01 avutil.h
-rw-r--r--   1 low-batt  staff  11998 Aug 18  2023 buffer.h
-rw-r--r--   1 low-batt  staff  32445 Jun 17 21:01 channel_layout.h
-rw-r--r--   1 low-batt  staff  17130 Jun 17 21:01 common.h
-rw-r--r--   1 low-batt  staff   9374 Aug 18  2023 dict.h
-rw-r--r--   1 low-batt  staff   5489 Aug 18  2023 error.h
-rw-r--r--   1 low-batt  staff  38049 Jun 17 21:01 frame.h
-rw-r--r--   1 low-batt  staff  24079 Jun 17 21:01 hwcontext.h
-rw-r--r--   1 low-batt  staff  14172 Aug 18  2023 imgutils.h
-rw-r--r--@  1 low-batt  staff   1726 Sep 22  2022 intfloat.h
-rw-r--r--   1 low-batt  staff  12766 Aug 18  2023 log.h
-rw-r--r--   1 low-batt  staff   2304 Aug 18  2023 macros.h
-rw-r--r--   1 low-batt  staff   3944 Apr 25  2023 mastering_display_metadata.h
-rw-r--r--   1 low-batt  staff   9563 Jun 17 21:01 mathematics.h
-rw-r--r--   1 low-batt  staff  20457 Jun 17 21:01 mem.h
-rw-r--r--   1 low-batt  staff  16165 Jun 17 21:01 pixdesc.h
-rw-r--r--   1 low-batt  staff  41797 Jun 17 21:01 pixfmt.h
-rw-r--r--   1 low-batt  staff   6286 Jun 17 21:01 rational.h
-rw-r--r--   1 low-batt  staff  10301 Jun 17 21:01 samplefmt.h
-rw-r--r--   1 low-batt  staff   4335 Jun 17 21:01 version.h
low-batt@gag libavutil (bump-mpv $%=)$

The .gitignore excludes most of those files from git:

low-batt@gag libavutil (bump-mpv $%=)$ cat .gitignore 
# Exclude everything except the FFmpeg headers IINA needs.
*
!.gitignore
!attributes.h
!avconfig.h
!avutil.h
!buffer.h
!channel_layout.h
!common.h
!dict.h
!error.h
!frame.h
!hwcontext.h
!imgutils.h
!intfloat.h
!log.h
!macros.h
!mastering_display_metadata.h
!mathematics.h
!mem.h
!pixdesc.h
!pixfmt.h
!rational.h
!samplefmt.h
!version.h
low-batt@gag libavutil (bump-mpv $%=)$ 

@low-batt Sorry I didn't check the gitginore. I saw this file was maintain by you, so please deal with this issue.

Updated libs on server & rebased. Merging.