Make audio track picker accept video files #4840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scvairy
commented
Mar 2, 2024
Comment on lines
+666
to
+669
| title: "Load external audio file", | ||
| chooseDir: false, | ||
| dir: currentDir, | ||
| sheetWindow: player.currentWindow, |
There was a problem hiding this comment.
Added new lines for better readability
Scvairy
commented
Mar 2, 2024
| chooseDir: false, | ||
| dir: currentDir, | ||
| sheetWindow: player.currentWindow, | ||
| allowedFileTypes: Utility.playableFileExt |
There was a problem hiding this comment.
It is actually Utility.supportedFileExt[.audio]! + Utility.supportedFileExt[.video]!, so I decided not to duplicate it and use existing static field. But I see its name makes no sense here ¯\_(ツ)_/¯
low-batt
approved these changes
Mar 3, 2024
|
Thanks for contributing to IINA! |
|
Thanks from me as well! The comments in the PR explaining the thinking behind the code changes were very helpful. |
svobs
pushed a commit
to svobs/iina-advance
that referenced
this pull request
Mar 8, 2024
svobs
added a commit
to svobs/iina-advance
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #3259
Description:
I've added union of video and audio types to allowedFileTypes in "Load external audio file". Selecting video file works out of the box for years in IINA, and was allowed until 1.0.7 (on 1.0.7 it works, but on newer versions doesn't).
It's time to fix it! 💛