Fixes & improvements to Subtitle Chooser #4833
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
164f8da to
424445f
Compare
2ed938a to
f08cb2a
Compare
|
Squashed + rebased to fix merge errors + improved commit msg. |
lhc70000
requested changes
Jun 27, 2024
f08cb2a to
9a95c4f
Compare
|
Rebased + pushed an update with all the suggested changes and more detailed commit message. |
Details:
• Improve text size of sub-heading and table items slightly
• Improve table style & border
• Remove time from upload date
• Remove rating from displayed attributes
• Add release year in parentheses
• Add up to 2 fraction digits to fps attribute's displayed value
• Add osd.sub_downloading ("Downloading %d subtitles") & reference it
while downloading instead of osd.sub_found
• Remove " Downloading…" from osd.sub_found to make it more
appropriate as a table heading
9a95c4f to
2362e7d
Compare
|
Merged via 1f87c39. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Like #4825 but makes additional changes:
osd.sub_found, previously set to%d subtitles found. Downloading…, was not exactly appropriate as the heading for the list of subtitles to download. It looks like this was done because it was used both for the subtitle list & for the actual "downloading" message. So I changed the existingosd.sub_foundmessage to remove theDownloading…part, added a newosd.sub_downloadingmessage whose English version isDownloading %d subtitles, and changed the "downloading" message to use this key instead.fpsattribute's displayed value.