Fix cursor disappears after clicking, #4748 #4767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will: - Change MainWindowController.workaroundCursorDefect to only hide the cursor if animationState is set to hidden - Change MainWindowController.performMouseAction to call hideUIAndCursor instead of hideUI This corrects the workaround for the AppKit method NSCursor.setHiddenUntilMouseMoves malfunctioning to only hide the cursor when the OSC is hidden. This commit also changes the behavior when mouse clicks are configured to hide the OSC to include hiding the cursor to match up with the behavior when the OSC is automatically hidden after a delay.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will:
MainWindowController.workaroundCursorDefectto only hide the cursor if animationState is set to hiddenMainWindowController.performMouseActionto callhideUIAndCursorinstead ofhideUIThis corrects the workaround for the AppKit method
NSCursor.setHiddenUntilMouseMovesmalfunctioning to only hide the cursor when the OSC is hidden.This commit also changes the behavior when mouse clicks are configured to hide the OSC to include hiding the cursor to match up with the behavior when the OSC is automatically hidden after a delay.
Description: