Fix discrepancies with new Open Subtitles API Results, #4749 #4755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will: - Add a guessit method to OpenSubClient class - Add a GuessitResponse struct to hold the results of a call to the Open Subtitles guessit API - Change the subtitles method to accept a GuessitResponse and pass information such as season and episode number as query parameters - Add a guessit method to OpenSub class - Change the searchForSubtitles method to accept a GuessitResponse and pass it on when calling OpenSubClient.subtitles - Change the OpenSub.Fetcher.fetch method to call guessit and pass the results to searchForSubtitles With these changes it is more likely that the results of searching for a particular episode of a TV series will be narrowed to subtitles for that episode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will:
With these changes it is more likely that the results of searching for a particular episode of a TV series will be narrowed to subtitles for that episode.
Description: