Display thumbnails in DAR instead of SAR #4736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62b0f6b to
0732ddd
Compare
low-batt
approved these changes
Dec 31, 2023
|
I pushed another commit to fix the aspect ratio issue for the mini player as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In some formats (like most of Japanese TV video formats), display aspect ratios (DAR) are different from the sample aspect ratio (SAR). A typical configuration is SAR 1440x1080i (4:3) w/ DAR 1920x1080 (16:9). So I changed to try to get the display aspect ratio from mpv to properly display the thumbnail.
Before:
After:
Testing video: https://drive.google.com/file/d/1tKMnXhpMBGbTLUh3uxFl6F4xdiB3nBtw/view?usp=drive_link