Add Screenshot button to On Screen Controller (addresses #4642 partially) #4648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
low-batt
approved these changes
Oct 13, 2023
|
I'm a junior IINA developer. We are now waiting for the senior developers to review and merge. I'm hoping they will free up and be able to merge PRs soon. Last I heard the plan was to start merging in preparation for a feature release. However as some regressions have been reported IINA may decide to just merge some critical fixes first and release that, before starting on the feature release. |
|
The pr looks clean & straightforward. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The following adds a screenshot button to the On Screen Controller. This allows one to quickly take a screenshot as one would use any other function that the OSC provides.
IINA-Demonstration-1.mp4