Key navigation fixes in player window input fields (fixes #3039, #3206) #4587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a04c4e4 to
777edba
Compare
d0362d6 to
38cbe41
Compare
|
Rebased + scaled down the changes so that only the text field issue is now addressed. The fix for table navigation was only halfway there anyway. |
This was
linked to
issues
Feb 11, 2024
More detail: • Add check for arrow keys in text fields to MainWindow & send to the text field instead of handling as mpv binding • Change views in sidebars to refuse first responder so that tabbing out of a text field doesn't add an unwanted focus ring around them.
38cbe41 to
8e13236
Compare
|
Rebased to fix merge problems + improved commit msg. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
TABorSHIFT+TABin a text field doesn't create an unusable glowing focus ring around one of them.