Skip to content

Fix the Advanced Settings Aren't Searchable, #4512 #4516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 5, 2024
Merged

Fix the Advanced Settings Aren't Searchable, #4512 #4516

merged 3 commits into from
Jan 5, 2024

Conversation

low-batt
Copy link
Contributor

This commit will:

  • Add SectionTitleTop hidden label to Advanced tab

  • Add SectionTitleLogging hidden label to Advanced tab

  • Add FunctionalButtonShowLog identifier to Show log viewer button on Advanced tab

  • Add FunctionalButtonLogDirectory identifier to Open log directory button on Advanced tab

  • Add FunctionalButtonShowConfig identifier to Show the config file in Finder button on Key Bindings tab

  • Add FunctionalButtonImportConfig identifier to Import an existing config file button on Key Bindings tab

  • Add FunctionalButtonDefaultApp identifier to Set IINA as the Default Application… button on Utilities tab

  • Add formSearchTerm method to PreferenceWindowController that removes extraneous characters from labels and titles

  • Correct the spelling of available on General tab

  • Change Use media keys to be Use system media control to match UI

  • Add a logLabelDict method to PreferenceWindowController that logs the search terms found by scanning NIBs

  • I have read CONTRIBUTING.md

  • This implements/fixes issue The Advanced Settings Aren't Searchable #4512.

Description:

@low-batt
Copy link
Contributor Author

NOTE: To reviewers, have a look at my post in the issue (#4512). That explains the changes and shows the search terms that are now being extracted from the settings panel NIBs.

My question for reviewers is whether I am being too aggressive in removing punctuation from the search terms. In other words should searching for "Layout:", with the ":" at the end return results? The changed code is stripping the colon, so now it will not be found. Of course as you are typing "Layout", unless you are a fast typist you will get results before you can type the colon.

Compare the debug output in the issue to see the changes.

@low-batt low-batt requested review from uiryuu and lhc70000 July 20, 2023 02:30
@low-batt low-batt linked an issue Nov 18, 2023 that may be closed by this pull request
The Advanced Settings Aren't Searchable #4512
Closed
@low-batt
Fix the Advanced Settings Aren't Searchable, #4512
92b98ba 
This commit will:
- Add SectionTitleTop hidden label to Advanced tab
- Add SectionTitleLogging hidden label to Advanced tab
- Add FunctionalButtonShowLog identifier to Show log viewer button on
  Advanced tab
- Add FunctionalButtonLogDirectory identifier to Open log directory
  button on Advanced tab
- Add FunctionalButtonShowConfig identifier to Show the config file in
  Finder button on Key Bindings tab
- Add FunctionalButtonImportConfig identifier to Import an existing
  config file button on Key Bindings tab
- Add FunctionalButtonDefaultApp identifier to Set IINA as the Default
  Application button on Utilities tab
- Add formSearchTerm method to PreferenceWindowController that removes
  extraneous characters from labels and titles
- Correct the spelling of available on General tab
- Change Use media keys to be  Use system media control to match UI
- Add a logLabelDict method to PreferenceWindowController that logs
  the search terms found by scanning NIBs
uiryuu
uiryuu requested changes Jan 3, 2024
View reviewed changes
Copy link
Member

@uiryuu uiryuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the plugins settings are not searchable as well. Is it intentional for now?

@low-batt
Fix the Advanced Settings Aren't Searchable, #4512
727b421 
This commit will:
- Add SectionTitleTop hidden label to Advanced tab
- Add SectionTitleLogging hidden label to Advanced tab
- Add FunctionalButtonEnableAdvanced identifier to Enable advanced
  settings button on Advanced tab
- Add FunctionalButtonShowLog identifier to Show log viewer button on
  Advanced tab
- Add FunctionalButtonLogDirectory identifier to Open log directory
  button on Advanced tab
- Add FunctionalButtonShowConfig identifier to Show the config file in
  Finder button on Key Bindings tab
- Add FunctionalButtonImportConfig identifier to Import an existing
  config file button on Key Bindings tab
- Add FunctionalButtonDefaultApp identifier to Set IINA as the Default
  Application button on Utilities tab
- Add SectionTitlePlugins hidden label to Plugins tab
- Add FunctionalButtonInstallGitHub identifier to Install from GitHub
  button on Plugins tab
- Add FunctionalButtonInstallLocal identifier to Install from a local
  package button on Plugins tab
- Add FunctionalButtonShowPlugin identifier to Show in Finder button on
  Plugins tab
- Add formSearchTerm method to PreferenceWindowController that removes
  extraneous characters from labels and titles
- Correct the spelling of available on General tab
- Change Use media keys to be Use system media control to match UI
- Add a logLabelDict method to PreferenceWindowController that logs
  the search terms found by scanning NIBs
@low-batt
Copy link
Contributor Author

low-batt commented Jan 4, 2024

I was avoiding the plugins settings over worries about merge conflicts. I have added them in this new commit. These are the terms from the plugins settings:

20:02:37.339 [iina][d] Plugins
20:02:37.339 [iina][d]   Plugins
20:02:37.339 [iina][d]     Uninstall
20:02:37.339 [iina][d]     Show in Finder
20:02:37.339 [iina][d]     Installed plugins
20:02:37.339 [iina][d]     Install from GitHub...
20:02:37.339 [iina][d]     Plugins
20:02:37.339 [iina][d]     Install from a local package

@low-batt
Fix the Advanced Settings Aren't Searchable, #4512
72d8b37 
This commit will:
- Add SectionTitleTop hidden label to Advanced tab
- Add SectionTitleLogging hidden label to Advanced tab
- Add FunctionalButtonEnableAdvanced identifier to Enable advanced
  settings button on Advanced tab
- Add FunctionalButtonShowLog identifier to Show log viewer button on
  Advanced tab
- Add FunctionalButtonLogDirectory identifier to Open log directory
  button on Advanced tab
- Add FunctionalButtonShowConfig identifier to Show the config file in
  Finder button on Key Bindings tab
- Add FunctionalButtonImportConfig identifier to Import an existing
  config file button on Key Bindings tab
- Add FunctionalButtonDefaultApp identifier to Set IINA as the Default
  Application button on Utilities tab
- Add SectionTitlePlugins hidden label to Plugins tab
- Add FunctionalButtonInstallGitHub identifier to Install from GitHub
  button on Plugins tab
- Add FunctionalButtonInstallLocal identifier to Install from a local
  package button on Plugins tab
- Add FunctionalButtonShowPlugin identifier to Show in Finder button on
  Plugins tab
- Add formSearchTerm method to PreferenceWindowController that removes
  extraneous characters from labels and titles
- Correct the spelling of available on General tab
- Change Use media keys to be Use system media control to match UI
- Add a logLabelDict method to PreferenceWindowController that logs
  the search terms found by scanning NIBs
- Add a trimWhitespaceSuffix method to the private String extension
- Correct an existing defect in the removedLastSemicolon method
- Change searchFieldAction to remove trailing whitespace and a
  trailing colon if present from the string to search for
@low-batt
Copy link
Contributor Author

low-batt commented Jan 5, 2024

After discussion with @uiryuu I have added stripping of any trailing whitespace or colon from the user's search string.

@low-batt low-batt merged commit e28a170 into develop Jan 5, 2024
@low-batt low-batt deleted the search-prefs branch January 5, 2024 22:19
Manantahir added a commit to Manantahir/iina that referenced this pull request Jan 30, 2024
@Manantahir
Revert "Fix the Advanced Settings Aren't Searchable, iina#4512 (iina#…
b3d1971 
…4516)"

This reverts commit e28a170.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uiryuu uiryuu uiryuu approved these changes

@lhc70000 lhc70000 Awaiting requested review from lhc70000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Advanced Settings Aren't Searchable
2 participants
@low-batt @uiryuu