-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fixes to Quick Settings regressions (fixes #4481, #4482) #4484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…generate en.lproj/QuickSettingViewController.strings. Fix broken "Custom…" localization ref. Fix some uses of "…" which were using "..." instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed one on the VIDEO
tab. And since an update is needed might as well include the fix for issue #4482. Trivial fix to this same XIB. See my comment in that issue.
I included the fix for #4482 and updated the description to note this.
Forgot to ask about that - it's item 4 in the description. I included the fix in the There's actually a lot I'm still unclear about as it comes to localizations & the workflow to/from Crowdin. I guess I've been assuming that one of of the core devs had ownership over it and would do some kind of regeneration from Crowdin and/or validation before each release. |
I believe the only update the en rule applies. I'm confused as to why it can't be linked to the old translation text. I guess we will need to check in with others as to how to handle this. |
I agree that we should release a fix for this (together with the VP9 hardware decoding problem). However I'm not sure whether crowdin will handle ID changes correctly. I will test it out today or tomorrow with @uiryuu. |
It seems the previous translations are still left in the .strings files; merge this to see how Crowdin behaves... |
@woshiniming007 thank you for reporting, but next time please report as a new defect because this one has already been closed. I have listed it in a new defect, #4588. |
Description:
QuickSettingsViewController.strings
files.iina/en.lproj/QuickSettingViewController.strings
in XCode. Include some fields which appeared to be missing. Requesting feedback on this.vFD-HU-RVz.title
toiuN-rN-jT7.ibShadowedLabels[6]
forCustom…
segmented button because it has changed form.