Skip to content

Conversation

svobs
Copy link
Contributor

@svobs svobs commented Jul 10, 2023


Description:

  1. Change IDs for several fields to their former values, so that they match the ones expected by QuickSettingsViewController.strings files.
  2. Change some uses of "..." to "…" in the XIB, to match standard style
  3. Regenerated iina/en.lproj/QuickSettingViewController.strings in XCode. Include some fields which appeared to be missing. Requesting feedback on this.
  4. Update vFD-HU-RVz.title to iuN-rN-jT7.ibShadowedLabels[6] for Custom… segmented button because it has changed form.
  5. Remove minimum value from subtitle audio delay number formatter.

…generate en.lproj/QuickSettingViewController.strings. Fix broken "Custom…" localization ref. Fix some uses of "…" which were using "..." instead.
@lhc70000 lhc70000 requested a review from uiryuu July 10, 2023 05:53
@low-batt low-batt linked an issue Jul 11, 2023 that may be closed by this pull request
Copy link
Contributor

@low-batt low-batt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one on the VIDEO tab. And since an update is needed might as well include the fix for issue #4482. Trivial fix to this same XIB. See my comment in that issue.
issue-4481

@svobs
Copy link
Contributor Author

svobs commented Jul 12, 2023

I included the fix for #4482 and updated the description to note this.

Missed one on the VIDEO tab.

Forgot to ask about that - it's item 4 in the description. I included the fix in the en localization, but wasn't clear if I was to update all versions of QuickSettingViewController.strings. I'm fine with doing that - just wanted to ask first, because I've been told in other cases to limit my changes to en.

There's actually a lot I'm still unclear about as it comes to localizations & the workflow to/from Crowdin. I guess I've been assuming that one of of the core devs had ownership over it and would do some kind of regeneration from Crowdin and/or validation before each release.

@svobs svobs changed the title Fixes to Quick Settings localization regressions (fixes #4481) Fixes to Quick Settings regressions (fixes #4481, #4482) Jul 12, 2023
@low-batt
Copy link
Contributor

I believe the only update the en rule applies. I'm confused as to why it can't be linked to the old translation text. I guess we will need to check in with others as to how to handle this.

@lhc70000
Copy link
Member

I agree that we should release a fix for this (together with the VP9 hardware decoding problem).

However I'm not sure whether crowdin will handle ID changes correctly. I will test it out today or tomorrow with @uiryuu.

@uiryuu uiryuu merged commit 9a109ae into iina:develop Jul 12, 2023
@uiryuu
Copy link
Member

uiryuu commented Jul 12, 2023

It seems the previous translations are still left in the .strings files; merge this to see how Crowdin behaves...

@uiryuu
Copy link
Member

uiryuu commented Jul 12, 2023

image

After applying this PR, the missing strings are back!

@raisin8010
Copy link

It seems there is still one string not fixed...
SCR-20230814-thgq

@svobs
Copy link
Contributor Author

svobs commented Aug 17, 2023

@woshiniming007 thank you for reporting, but next time please report as a new defect because this one has already been closed. I have listed it in a new defect, #4588.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting negative audio delay using text field is not working lost localization of many strings
5 participants