Change "Music Mode" menu item to "Enter Music Mode"/"Exit Music Mode" based on status (closes #4463) #4467
Conversation
There was a problem hiding this comment.
The somewhat confusing IINA rules on localization require both the base and english localization files be updated. The rest are updated through Crowdin. So Localizable.strings under en.lproj also needs to be updated as a part of this PR.
I've been confused as to why we have to duplicate strings like this. Seems wrong. This PR got me to look into that. From Enabling Base Internationalization:
Xcode modifies your project folder according to the selections you make in this dialog. Xcode creates a Base.lproj folder in your project folder and adds to it the resource files you select. Xcode creates a language folder for the development language but only adds resources that need translation to the folder. For example, if you select English as the development language, Xcode inserts the resource file in the Base.lproj project folder but not the en.lproj folder because the resource is already in English.
Checking info.plist confirms the development language is set to English:
<key>CFBundleDevelopmentRegion</key>
<string>en</string>From the Apple documentation it sounds like en.lproj is not needed.
A separate issue for another day…
And here I was feeling clever that I finally got it right! I made another commit with the additions.
Interesting! I played with this and you are correct. This file appears to be [worse than] redundant.
But looks like a trivial fix. Can't resist this low-hanging fruit. I will file a bug report and PR. |
2ab94d3 to
24910bb
Compare
|
Sorry, inadvertently committed extra lines. Force-pushed the correct commit... |
24910bb to
8d1653d
Compare
|
Thanks! |
Description:
See issue #4463.