Changes look good, but I think there is another defect lurking. The iina-cli does not require use of the --mpv- prefix:

mpv Option:
Raw mpv options without --mpv- prefix. All mpv options are supported here.
Example: --volume=20 --no-resume-playback

But for some reason only --mpv-shuffle is working for me. When I tested --shuffle the playlist was not shuffled. Possibly something is wrong with argument processing in AppDelegate.

Well...this is interesting. It seems that CommandLineStatus was putting args which don't start with --mpv- into a separate array called iinaArguments, and then...doing nothing with that array ever after. The end result is that mpv options without the --mpv- prefix are being ignored.

This behavior doesn't make sense. Very odd that this wasn't noticed before. I checked some previous commits, going as far as the v1.3.1 tag, but it seems this behavior is not new. I worked on this code before but somehow missed it.

Maybe it's is a bit scope creepy, but I made another commit which removes the unused array and instead passes the previously unhandled arguments to the mpv core. This will allow --shuffle (and other mpv options) to be used without needing the prefix.

Yes, odd that this is so broken. The iina-cli help is very clear that this should work.

Testing with:

low-batt@gag MacOS$ ./iina-cli --shuffle --pip  ~/Movies/

The mpv log shows:

[   0.040][v][cplayer] Set property: shuffle="yes" -> 1
[   0.040][v][cplayer] Set property: pip="yes" -> -3

Shuffle is working now. I'm thinking IINA should be filtering out the known iina-cli options such as pip.

OK. I see now I'm getting pulled deeper into this. Rabbit holes everywhere! 🤣

I'm thinking IINA should be filtering out the known iina-cli options such as pip.

Yes, you're right. The IINA args should be processed before the mpv args, and should not be passed to mpv. I see that een with my fix, they are not.

I think I should back out my CommandLineStatus changes and put them into a new issue. It is a completely separate problem than the one this PR was meant to address, and will require more new lines of code than the original problem did.

Agree. The problem with mpv options can be a separate issue.

Thanks!