Accept seconds-only format string in VideoTime #3375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VideoTime convenience initializer now accepts a bare `second` format string, in addition to previously accepted `minute:second` and `hour:minute:second`. This is consistent with the `init(_ second: Double)` designated initializer, and allows users to just input bare second values in the _Jump to..._ dialog, so instead of `0:40` and `1:20` one could enter `40` and `80`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VideoTime convenience initializer now accepts a bare
secondformatstring, in addition to previously accepted
minute:secondandhour:minute:second.This is consistent with the
init(_ second: Double)designatedinitializer, and allows users to just input bare second values in the
Jump to... dialog, so instead of
0:40and1:20one could enter40and80.Description: