Skip to content

Change reveal to show in UI & codebase #3982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Conversation

uiryuu
Copy link
Member

@uiryuu uiryuu commented Oct 13, 2022

Changes in UI:

  • Preferences > Key Bindings > "Reveal config file in Finder" -> "Show the config file in Finder"
  • Preferences > Plugin > "Reveal in Finder" -> "Show in Finder"
  • Playback History > (context menu) > "Reveal in Finder" -> "Show in Finder"
  • Config file existing error message: "This should not happen. Choose OK to overwrite, Cancel to reveal the file in Finder." -> "This should not happen. Choose OK to overwrite, Cancel to show the file in Finder.";

Other changes:

  • In Localizables.strings, the key name "pl_menu.reveal_in_finder" has been renamed to "pl_menu.show_in_finder"
  • Many function has been renamed from "reveal" to "show"

The only "reveal" I didn't change is the button in the OSD after a screenshot is taken. I can't come up with a good word for that.

Since it contains changes to xib files, some changes may seem messy, but I've tried to make it as clean as possible.

Copy link
Contributor

@low-batt low-batt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changes for language files that are in Git, but missing from the Xcode project. What is the story behind that? In Git I see .lproj directories for:
ar
be
bg
bn
el
eu
fa
he
hr
hy
id
is
kn
iv
mk
ml
no
sl
sr-CS
sr-Cyrl
sr
ta
th
ug
ur
vi

@uiryuu
Copy link
Member Author

uiryuu commented Oct 14, 2022

@low-batt Good catch! I’ll update.

Those languages which are not in Xcode is because they are too incomplete to be included in the release, when the complete enough, I’ll add them into Xcode manually.

@uiryuu uiryuu merged commit b17fa5d into develop Nov 8, 2022
@uiryuu uiryuu deleted the change-reveal-to-show branch November 8, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Reveal in Finder" should be renamed to "Show in Finder"
2 participants