Fix white window after entering PIP when pausing #3973
Conversation
We need to redraw a frame after entering PIP when pausing, and previously we perform such redraw in the next `layout`. However, it now takes two `layout`s before finishing entering PIP. This was tested on macOS 13 beta and macOS 12.6. Changing the pending flag into a counter and redrawing twice solve the problem.
|
I pulled the PR and tested. I don't usually use PIP, so I'm unfamiliar with this feature. The bad behavior I encountered was that with playback paused exiting PIP would sometimes leave me with a fully black window. This is running on my MacBookPro18,2 under macOS 12.6 and built with Xcode 14.0. |
Did you test on dev branch? This pr doesn't change behavior when exit, so the behavior should be the same.
I tested on macOS 13 beta and 12.6 virtual machine, didn't reproduce. |
|
I did this to test the PR: git fetch origin pull/3973/head:pr3973
git checkout pr3973In videoView.pendingRedrawAfterEnteringPIPCount = 2I think I have the PR sources. I tried reproducing the black screen on develop and it didn't reproduce for me. It doesn't do it every time. I pause the video and then go in and out of PIP until I'm left with a black screen. For the following screen recording it happened on the first try: |
* Fix white window after entering PIP when pausing We need to redraw a frame after entering PIP when pausing, and previously we perform such redraw in the next `layout`. However, it now takes two `layout`s before finishing entering PIP. This was tested on macOS 13 beta and macOS 12.6. Changing the pending flag into a counter and redrawing twice solve the problem. * Change variable name upon review
We need to redraw a frame after entering PIP when pausing, and previously we perform such redraw in the next
layout. However, it now takes twolayouts before finishing entering PIP. This was tested on macOS 13 beta and macOS 12.6.Changing the pending flag into a counter and redrawing twice solve the problem.