Close log build date, git branch and commit hash, #3970 #3971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca486f1 to
9232d54
Compare
This commit will: - Add custom keys to Info.plist to contain build information - Enable preprocessing of the Info.plist file in the Xcode build - Enable use of an Info.plist header file in the Xcode build - Add a shell script write_info_plist_header.sh that generates the Info.plist header file - Add a new Xcode build phase to execute the script - Add a new logBuildDetails method to AppDelegate With these changes IINA will log a message during startup containing the build date, git branch and commit hash.
uiryuu
approved these changes
Nov 9, 2022
| ); | ||
| runOnlyForDeploymentPostprocessing = 0; | ||
| shellPath = /bin/sh; | ||
| shellScript = "iina/write_info_plist_header.sh\n"; |
There was a problem hiding this comment.
Xcode demands it. I was unable to remove it within Xcode editing the build phase. So with Xcode shutdown I removed it using Emacs. Confirmed with git diff. Brought up Xcode. Confirmed build still worked. Checked git status. No change. Xcode put the newline back in.
There was a problem hiding this comment.
Then it should be ok as long as it works
iina/Info.plist
Outdated
| @@ -611,7 +617,7 @@ Released under GPLv3.</string> | |||
| <string>public.audio</string> | |||
| </array> | |||
| <key>UTTypeDescription</key> | |||
| <string>Monkey's Audio Lossless Audio</string> | |||
| <string>Monkey's Audio Lossless Audio</string> | |||
There was a problem hiding this comment.
Also please revert this. I've seen Xcode automatically jumped between ' and ' multiple times...
Updated to address review comments. This commit will: - Add custom keys to Info.plist to contain build information - Enable preprocessing of the Info.plist file in the Xcode build - Enable use of an Info.plist header file in the Xcode build - Add a shell script write_info_plist_header.sh that generates the Info.plist header file - Add a new Xcode build phase to execute the script - Add a new logBuildDetails method to AppDelegate With these changes IINA will log a message during startup containing the build date, git branch and commit hash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will:
With these changes IINA will log a message during startup containing the build date, git branch and commit hash.
Description: