Resolve symlinks when comparing recent files against last played file #3789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21e6c65 to
e91b627
Compare
2d6f854 to
5f1149f
Compare
5f1149f to
824ef95
Compare
uiryuu
approved these changes
Nov 5, 2022
|
Pending one more approve then we can merge it! |
saagarjha
approved these changes
Nov 5, 2022
Ah, my Swift newbie code! Thanks Co-authored-by: Saagar Jha <saagar@saagarjha.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The last played file is checked against the recent files list so that it doesn't appear twice, but if one is a symlink, it can give a false negative and result in a duplicate listing. This seems to be a bigger problem for files in /tmp and /var, which Apple now links to /private/tmp and /private/var, so they can have different paths depending on which MacOS API they came from.
This fix adds
resolvingSymlinksInPath()to both sides of the comparison, which is needed to normalize both paths. Apple treats /var and /tmp a bit strangely. See this discussion.