Update the network prefetch preference's default label #3780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now matching the change in 14f785b.
1 task
1 task
|
Thanks for posting this PR. I created an issue for it to give it more visibility. I'm unsure about the IINA conventions on using Crowdin, but I think the convention on translations is to include the english translation in the commit and not include other translations to avoid merge conflicts with Crowdin. If I am correct about that then this line in the English version of PrefNetworkViewController.strings needs to be updated: See if others confirm that is the convention. |
|
Thanks for your PR; I'll change the en.lproj accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The default value for this preference appears to have changed in 14f785b (iina/Preference.swift line 755), but the label wasn't updated, leading to a mismatch:
This PR updates the label's text, though translations may also need to be updated on Crowdin.
(This is a copy of #3658. The author appears to have deleted their fork, permanently closing the PR.)