Ref: #3701 (comment)

I tested the PR and it worked for me. The only thing I find odd about the changes is this:

low-batt@gag iina (pr3704)$ defaults read com.colliderli.iina | grep -i loop
    enableFileLoop = 1;
    enablePlaylistLoop = 1;

These are not global controls, one IINA window can have file loop enabled while another window has it disabled. Same for playlist loop. So it seems odd to be persisting a global setting in user defaults. The persisted settings are ignored. Even though they are both enabled in defaults when IINA is restarted both are disabled when IINA comes up. That seems like the correct behavior as if you had two IINA windows open at the time you quit IINA with settings enabled in one and not in the other it is not clear which should "win" and be used when IINA restarts.

Saving preference of file loop and playlist loop is useful when people use IINA as a music player. Although IINA is mainly a video player, it does support music (mini) mode.

The persisted settings are ignored.

I tested it with single window and it worked for me. As for multi window, I didn't test that case.

That seems like the correct behavior as if you had two IINA windows open at the time you quit IINA with settings enabled in one and not in the other it is not clear which should "win" and be used when IINA restarts.

The last changed settings should win, like you open two text editors for one file.

In my honest opinion multi window for a media player is over-design. I don't think it's very useful to watch 2 movies at the same time.

Well I'm confused. It is definitely not working for me. I checked IINA+ and not working for me there either. As can be seen above both kinds of looping are enabled in the persisted user defaults, but when I start IINA and play a file, neither items are checked on the Playback menu. I hacked in the following code to MPVController.mpvInit:

setUserOption(PK.enableFileLoop, type: .other, forName: MPVOption.PlaybackControl.loopFile) { key in
  return Preference.bool(for: key) ? "inf" : "no"
}
setUserOption(PK.enablePlaylistLoop, type: .other, forName: MPVOption.PlaybackControl.loopPlaylist) { key in
  return Preference.bool(for: key) ? "inf" : "no"
}

And restarted IINA and then the menu items were both initially enabled. Maybe some changes were lost at some point during all the merging? Can you confirm it is still working for you?

The example of when preserving this setting is useful for video playback would be continuous playback for advertising, kiosk, demos, that kind of thing.

I am embarrassed to say that I am a multi-window user. Usually it is because I was in the middle of watching some instructional video and got interrupted. I know I can depend upon watch later to remember where I was, but I usually leave the window open so I don't forget to come back to it.

I removed preference related code. I'll just keep it in iina-plus

I have two quick comments:

• I do hope we have vector images for all UI elements, and the icon should derive from the current file loop icon. I will try to draw a new one.
• The standard logic in a music player should be: we have only one button for looping, and clicking the button switches among "off", "playlist loop" and "file loop" mode. It makes no sense to have two buttons, with both playlist loop and file loop enabled.

Hi @CarterLi, could you remove the changes to the button for now? I hope the playlist related fixes can be merged into 1.3.0, but we need to discuss more on the UI changes.

Hi @CarterLi, could you remove the changes to the button for now? I hope the playlist related fixes can be merged into 1.3.0, but we need to discuss more on the UI changes.

Done.

However I want to say that loop file is very useful for a music player. Please add it sometime

Thanks. Sure!