-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Description
System and IINA version:
- macOS 13.6.3
- IINA 1.3.4 + PR feat: enable hebrew locale #4922
Expected behavior:
The Audio delay
setting on the AUDIO
tab of the quick settings panel is displayed as intended in languages other than English.
Actual behavior:
The Audio delay
setting contains a text field after the slider that can be used to enter a value for the delay. After the text field is another text field giving the units of the value. In English this field shows s
. Currently IINA does not support any right to left languages. However PR #4922 enables Hebrew. If you build IINA with that pull request and set Hebrew as the language then the units (שנ'
) do not fit:
This problem was reported by @ShlomoCode in issue #4776. As that issue reports quite a few RTL related problems I have created this issue to focus just on this particular problem.
Steps to reproduce:
-
Pull PR feat: enable hebrew locale #4922
-
Open the IINA project in Xcode
-
Under the
Product
menu open theScheme
menu and selectEdit Scheme…
-
Click on the
Options
tab -
Scroll down to the
App Language
setting -
In the pull down select
Hebrew
-
Start IINA running under Xcode
-
Start playing a video
-
Press ⇧⌘A to show the audio panel
-
Notice the units shown for
Audio delay
is wrapped into multiple lines -
MPV does not have this problem.
mpv does not support localization.
How often does this happen?
Every time.