Skip to content

Missing localization for Save Downloaded Subtitle #4610

@low-batt

Description

@low-batt

System and IINA version:

  • macOS 13.5
  • IINA 1.3.3

Expected behavior:
IINA shows text, not localization tags.

Actual behavior:
Localization changes in commit 5af7c71 have been lost.

I believe what happened was that during review I was asked to remove translations and did so thinking that meant all but the base translations, not base + en. This was before the contributing document was updated to clarify how localizations must be handled.

save-panel

save-downloaded

Steps to reproduce:
Download subtitles and then click on Save Downloaded Subtitles under the Subtitles menu.

  • MPV does not have this problem.

How often does this happen?
Every time.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions