How are you initiating taking a screenshot?
Clicking the Take a screenshot menu item in the Playback menu?
Pressing a key?
If using a key, in IINA's settings on the Key Bindings tab, what configuration are you using?

If you are pressing the "s" key and using the mpv key bindings then I think I reproduced the problem you are reporting.

The feature in question is the Include subtitles setting found in the Screenshots section of the General tab in IINA's settings.

Many of IINA's settings directly control mpv options. This one does not. IINA is trying to add functionality on top of mpv and there are problems with the implementation.

The mpv feature in question is the screenshot command:

screenshot <flags>
Take a screenshot.

Multiple flags are available (some can be combined with +):

<subtitles> (default)
Save the video image, in its original resolution, and with subtitles. Some video outputs may still include the OSD in the output under certain circumstances.
<video>
Like subtitles, but typically without OSD or subtitles. The exact behavior depends on the selected video output.
<window>
Save the contents of the mpv window. Typically scaled, with OSD and subtitles. The exact behavior depends on the selected video output.
<each-frame>
Take a screenshot each frame. Issue this command again to stop taking screenshots. Note that you should disable frame-dropping when using this mode - or you might receive duplicate images in cases when a frame was dropped. This flag can be combined with the other flags, e.g. video+each-frame.

From the above documentation we can guess that IINA is trying to avoid having multiple menu items (Screenshot with subtitles / Screenshot without subtitles) and instead have a setting that tells it what argument to pass when sending the screenshot command to mpv.

The special IINA processing is found in PlayerCore:

iina/iina/PlayerCore.swift

Lines 755 to 764 in 1af17db

    
           func screenshot() { 
        
             guard let vid = info.vid, vid > 0 else { return } 
        
             let saveToFile = Preference.bool(for: .screenshotSaveToFile) 
        
             let saveToClipboard = Preference.bool(for: .screenshotCopyToClipboard) 
        
             guard saveToFile || saveToClipboard else { return } 
        
             let option = Preference.bool(for: .screenshotIncludeSubtitle) ? "subtitles" : "video" 
        
             mpv.asyncCommand(.screenshot, args: [option], replyUserdata: MPVController.UserData.screenshot) 
        
           }

One thing I would change is the guard statement that returns if neither saveToFile nor saveToClipboard have been enabled. That statement should emit a log message indicating that is why a screenshot was not taken.

This code also shows a second IINA customization. The replyUserdata specified allows IINA to recognize the reply sent by mpv when the asynchronous screenshot command finishes. When that happens the PlayerCore method screenshotCallback is called. One of the features that provides is the prevue of the screenshot in the OSD.

In my testing this worked for me until I switched to the mpv key bindings. Searching for "screenshot" shows the following bindings:

Key	Action
s	screenshot
S	screenshot video
Ctrl+s	screenshot window
Alt+s	screenshot each-frame

The inclusion of screenshot window is a defect. That command is tied to the mpv UI. Executing it fails:

[ 534.841][d][cplayer] Run command: screenshot, flags=73, args=[flags="window", legacy="unused"]
[ 534.841][e][cplayer] Taking screenshot failed.

In IINA 1.3.2 pressing "s" invokes the menu item Take a Screenshot, which calls the PlayerCore method. In IINA 1.3.3 pressing "s" does not invoke the menu item even though that item still shows a keyboard shortcut. This is a regression.

Key presses that do not trigger menu items are processed by the handleKeyBinding method in PlayerWindowController. That code is missing special handling IINA is attempting to layer on top of mpv and sends the command directly to mpv. This also explains why a preview of the screenshot is not shown in the OSD.

The handleKeyBinding method needs to be changed to provide IINA's special processing when the key has been bound to the screenshot command. The code in PlayerCore will need to be updated to handle an argument having already been supplied.

	func screenshot() {
	guard let vid = info.vid, vid > 0 else { return }
	let saveToFile = Preference.bool(for: .screenshotSaveToFile)
	let saveToClipboard = Preference.bool(for: .screenshotCopyToClipboard)
	guard saveToFile \|\| saveToClipboard else { return }

	let option = Preference.bool(for: .screenshotIncludeSubtitle) ? "subtitles" : "video"

	mpv.asyncCommand(.screenshot, args: [option], replyUserdata: MPVController.UserData.screenshot)
	}

Uh oh!

Subtitles are included in screenshots even when it's disabled in settings #4582

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions