Skip to content

Multiple keys bound to the same menu item results in a random key being chosen #3831

@svobs

Description

@svobs

System and IINA version:

  • macOS 12.4
  • IINA 1.3.0 Build 131

Take a look at the bindings for seek 5 (mapped to both l and RIGHT), and seek -5 (mapped to both j and LEFT):
Screen Shot 2022-06-06 Forward Backward One

Screen Shot 2022-06-06 Forward Backward Two

Choose a binding which is known to show up as a menu item (like seek 5 in this example), then add two or more lines to the input bindings mapping different keys to the same binding.

Expected behavior:
When a binding is mapped to multiple keys, the bottom-most-listed key should always be the one displayed in the menu

Actual behavior:
Which key is chosen seems random, and usually changes every time the list of bindings is changed in the Preferences (even for changes unrelated to these bindings)

Steps to reproduce:

  1. Open IINA and go to Preferences > Key Bindings.
  2. As shown above, add two or more actions for something in the menu, like seek 5, mapping them to different keys.
  3. Observe which key is listed in the menu.
  4. Remove some unrelated binding
  5. Observe that a different key is listed in the menu. If not, remove another binding and observe again, and it will usually change.
  • MPV does not have this problem.

How often does this happen?
Most of the time

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions