Skip to content

Custom key binding ignored #3692

@low-batt

Description

@low-batt

System and IINA version:

  • macOS 12.3.1
  • IINA 1.2.0

Expected behavior:
When a key is pressed IINA executes the commands assigned in a custom key binding.

Actual behavior:
IINA ignored the key binding.


Steps to reproduce:

  • Open IINA / Preferences
  • Click on Key Bindings
  • Select IINA Default
  • Click Duplicate
  • Click + to add a new binding
  • Add an additional binding for the RIGHT (arrow) key with the action seek 60 exact
  • Add an additional binding for the LEFT (arrow) key with the action seek -60 exact
  • This adds a second definition for these keys
  • Restart IINA to insure new preferences are being used
  • Play video
  • Open Playback menu
  • Notice that the menu item Step Forward 5s is still bound to the right arrow key
  • Notice that the menu item Step Backward 5s is still bound to the left arrow key
  • Test the right and left arrow keys
  • New binding are ignored and IINA continues to seek by 5 seconds
  • MPV does not have this problem.

This is a problem in IINA.

How often does this happen?
Every time.

I will post an analysis of the root cause and a proposed fix.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions