Crash when screenshotting with long video title (No error display) #3334
Description
This is a bug in mpv in crashing with long video titles since it saves files by default containing the full filename. macOS filename limit is 255 characters. But, streams can often have far more than 255 character filenames. Iina will then crash with no error display. This should be handled better, likely with an error display that it can't save a file. You could attempt to truncate this to 255 characters as well but that approach doesn't seem ideal.
- macOS 10.15.7
- IINA 1.1.2 Build 128
[ 5.892][d][global] user path: '/Users/drewbitt/Pictures/Screenshots' -> '/Users/drewbitt/Pictures/Screenshots'
[ 5.892][v][cplayer] Starting screenshot: '/Users/drewbitt/Pictures/Screenshots/CpMEKnGjK_3okdJGWD1cW5pqCjYWfoVenzgwG239NfKKzVU-5KTYVh2-FKS1whmCRiG0HKco5_Qeoc5KDcrvzd1Pkb5QLoJ954fnjeIcp3_O5HbADC-BSvW2zGpkVkYA0tQ-KntJpWEeCEAPSG_D2LeNUIA-S8T1BR1y2gR4aOAd-0ROzkPn_0a9VsSLYp3KZffPdI6u6j1BfZDPnRvU2n4sVLEQUSa_7Cp4yvOrKCfLOxgcpVbeHRHDp2dLiDHW366aI4c6l0f-wFgj6WgPbyHHz5wuZjC95mso0CGyjmj0l-kT_6H8J2qQ7MDdAVKGwKrF7pAYTGROATeB7ldUgr8VR9N7Zac1YtPKikqlVF_OXMuLirgu5mP0ZOPPgirRiwXXt_Ax4nVb15mIagu_JWviYMl0AT3hPvIhBKEMqIGYrST0xb7QIcIWs5Iz3VpEB1slBvTLzhfRM0n_iJ0-JOaqyP9y0PXmzDyUj3aflUBxDyIPzNGSSNaJ7Vvs3OWHqgp4cXjGXg6M99dYUXS8CA5D8WkAZ5u2mig5lDBGAmQj3OdSu0jqr1q33F7mRqz7_5vCqagak0SF8VvbOIqDm0ACdlcDjwtmR7W6x7qfwwaCvSnSeaAgHJJzrG7ggN4QRzETpAnWY99zRcQtevgp2RQkMqLE2qtUr87b-xHjVCfuz3U-Ek1OxD6uRGq8-4emTwxFUBRUEhBsdiA3xgCW5CwhhduDVp_mGgwR5yRZrZfgfRH3YI0-0001.png'
[ 5.892][d][ffmpeg] SwScaler: reducing / aligning filtersize 1 -> 4
[ 5.893][d][ffmpeg] SwScaler: reducing / aligning filtersize 7 -> 8
[ 5.893][d][ffmpeg] SwScaler: reducing / aligning filtersize 1 -> 1
[ 5.893][d][ffmpeg] SwScaler: reducing / aligning filtersize 7 -> 6
[ 5.893][v][ffmpeg] swscaler: Lanczos scaler, from nv12 to rgb24 using MMXEXT
[ 5.893][d][ffmpeg] swscaler: 1920x1080 -> 1920x1080
[ 5.920][e][cplayer] Error opening '/Users/drewbitt/Pictures/Screenshots/CpMEKnGjK_3okdJGWD1cW5pqCjYWfoVenzgwG239NfKKzVU-5KTYVh2-FKS1whmCRiG0HKco5_Qeoc5KDcrvzd1Pkb5QLoJ954fnjeIcp3_O5HbADC-BSvW2zGpkVkYA0tQ-KntJpWEeCEAPSG_D2LeNUIA-S8T1BR1y2gR4aOAd-0ROzkPn_0a9VsSLYp3KZffPdI6u6j1BfZDPnRvU2n4sVLEQUSa_7Cp4yvOrKCfLOxgcpVbeHRHDp2dLiDHW366aI4c6l0f-wFgj6WgPbyHHz5wuZjC95mso0CGyjmj0l-kT_6H8J2qQ7MDdAVKGwKrF7pAYTGROATeB7ldUgr8VR9N7Zac1YtPKikqlVF_OXMuLirgu5mP0ZOPPgirRiwXXt_Ax4nVb15mIagu_JWviYMl0AT3hPvIhBKEMqIGYrST0xb7QIcIWs5Iz3VpEB1slBvTLzhfRM0n_iJ0-JOaqyP9y0PXmzDyUj3aflUBxDyIPzNGSSNaJ7Vvs3OWHqgp4cXjGXg6M99dYUXS8CA5D8WkAZ5u2mig5lDBGAmQj3OdSu0jqr1q33F7mRqz7_5vCqagak0SF8VvbOIqDm0ACdlcDjwtmR7W6x7qfwwaCvSnSeaAgHJJzrG7ggN4QRzETpAnWY99zRcQtevgp2RQkMqLE2qtUr87b-xHjVCfuz3U-Ek1OxD6uRGq8-4emTwxFUBRUEhBsdiA3xgCW5CwhhduDVp_mGgwR5yRZrZfgfRH3YI0-0001.png' for writing!
[ 5.920][e][cplayer] Error writing screenshot!
and a crash
Expected Behavior: Tells you if it can't screenshot and doesn't simply crash with no error