Skip to content

Menu items buttons don't reflect the current state #3116

@WowbaggersLiquidLunch

Description

@WowbaggersLiquidLunch

There are many menu items and buttons in IINA that fall in the "toggled menu items" category (and the undocumented equivalent for buttons). However, they are not implemented as such. For example:

Screen Shot 2020-09-20 at 14 13 45 Redacted

"Show Quick Settings Panel" should be "Hide Quick Settings Panel" when the panel is already shown.

Screen Shot 2020-09-20 at 14 19 14

"Toggle Picture-in-Picture" button stay as SF Symbol pip.enter, when it should be pip.exit.

System and IINA version:

  • macOS 10.15.6 (19G2021)
  • IINA 1.1.0-beta1 Build 121

Expected behavior:

Menu item titles and button images should adapt to the application/window/player's current state.

Actual behavior:

Menu item titles and button images do not adapt to the application/window/player's current state.


I think I'm able to fix it, if the maintainers think this should be fixed.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions