Fix checkboxes in join string #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the last commit is not necessary |
The checkboxes doesnt work like it should. It does not add the trailing spaces if the delete training spaces is unchecked nor add the blank space if the blank space is unchecked but it is up to you if you want to fix it. Let me know if you need me to do the example and the tour in the join page |
|
It shouldn't add a trailing space if the delete training spaces is unchecked. |
|
Okay will do
…On Sun, Jun 23, 2024, 5:05 PM Ibrahima G. Coulibaly < ***@***.***> wrote:
It shouldn't add a trailing space if the delete training spaces is
unchecked.
For now ignore it. It is working. Go ahead with the examples.
I added an utility function to create a tool. You can see it in the readme
—
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZZOAAK6HO37Y5MYNQYMF3LZI5PELAVCNFSM6AAAAABJYX7MEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBVGM3TAOJRGM>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix the checkboxes in the string join so when not checked, the delete blank and delete trailing spaces will not delete. This makes the omni-tools better than https://onlinetexttools.com/join-text#tour since their checkboxes does not work