Skip to content

refactor!: remove react frontend + re-enable disabled integration tests (backport #4744) #4756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 9, 2025
Merged

refactor!: remove react frontend + re-enable disabled integration tests (backport #4744) #4756

merged 6 commits into from
Jul 9, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 3, 2025

ref: ignite/web#292
ref: #4414

This is an automatic backport of pull request #4744 done by Mergify.

@julienrbrt @mergify
refactor!: remove react frontend + re-enable disabled integration tes…
0b1af1e 
…ts (#4744)

* refactor!: remove react frontend + re-enable disabled integration tests

* deprecate command and no-op it

* lint

* bump web to v1.0.8

* remove hooks

* improvements

* update index.ts.tpl

* fix

* improve ux

* add pnpm instructions

* fixes

* fix integration test

* rename

* uncomment other test

* updates

---------

Co-authored-by: Danilo Pantani <danpantani@gmail.com>
(cherry picked from commit d1bf508)

# Conflicts:
#	docs/docs/03-clients/04-react.md
#	go.mod
#	go.sum
#	ignite/cmd/generate.go
#	ignite/cmd/generate_hooks.go
#	ignite/cmd/scaffold_react.go
#	ignite/config/chain/base/config.go
#	ignite/config/chain/config.go
#	ignite/pkg/cosmosgen/cosmosgen.go
#	ignite/services/chain/generate.go
#	ignite/services/scaffolder/scaffolder.go
#	integration/app.go
#	integration/client.go
#	integration/cosmosgen/bank_module_test.go
#	integration/cosmosgen/cosmosgen_composables_test.go
#	integration/cosmosgen/cosmosgen_hooks_test.go
#	integration/cosmosgen/custom_module_test.go
@mergify mergify bot added the conflicts label Jul 3, 2025
@mergify mergify bot requested a review from ilgooz as a code owner July 3, 2025 22:19
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Jul 3, 2025

Cherry-pick of d1bf508 has failed:

On branch mergify/bp/release/v28.x.y/pr-4744
Your branch is up to date with 'origin/release/v28.x.y'.

You are currently cherry-picking commit d1bf508a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   changelog.md
	modified:   docs/docs/03-clients/03-vue.md
	modified:   ignite/cmd/scaffold_vue.go
	modified:   ignite/pkg/cosmosgen/generate_composables.go
	modified:   ignite/pkg/cosmosgen/templates/composable/index.ts.tpl
	modified:   ignite/pkg/cosmosgen/webtemplates.go
	modified:   ignite/templates/app/files/readme.md.plush
	deleted:    integration/cosmosgen/bank_module_test.ts
	modified:   integration/cosmosgen/cosmosgen_test.go
	deleted:    integration/cosmosgen/custom_module_test.ts
	modified:   integration/env.go
	modified:   integration/exec.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by them: docs/docs/03-clients/04-react.md
	both modified:   go.mod
	both modified:   go.sum
	both modified:   ignite/cmd/generate.go
	deleted by them: ignite/cmd/generate_hooks.go
	both modified:   ignite/cmd/scaffold_react.go
	both modified:   ignite/config/chain/base/config.go
	both modified:   ignite/config/chain/config.go
	both modified:   ignite/pkg/cosmosgen/cosmosgen.go
	both modified:   ignite/services/chain/generate.go
	both modified:   ignite/services/scaffolder/scaffolder.go
	both modified:   integration/app.go
	deleted by them: integration/client.go
	deleted by them: integration/cosmosgen/bank_module_test.go
	both modified:   integration/cosmosgen/cosmosgen_composables_test.go
	deleted by them: integration/cosmosgen/cosmosgen_hooks_test.go
	deleted by them: integration/cosmosgen/custom_module_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested review from Pantani, julienrbrt and toschdev as code owners July 3, 2025 22:19
@mergify mergify bot mentioned this pull request Jul 3, 2025
Merged
@github-actions github-actions bot added component:docs Documentation additions or improvements. component:ci CI/CD workflow and automated jobs. component:templates component:configs component:cmd type:services Service-related issues. type:internal component:packages labels Jul 3, 2025
@julienrbrt julienrbrt self-assigned this Jul 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit 17f9da4):

https://igntservices-docs--pr4756-mergify-bp-release-v-hp7f01fn.web.app

(expires Wed, 16 Jul 2025 08:43:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5

@julienrbrt julienrbrt marked this pull request as draft July 3, 2025 22:30
@julienrbrt julienrbrt marked this pull request as ready for review July 9, 2025 08:41
julienrbrt
julienrbrt previously approved these changes Jul 9, 2025
View reviewed changes
@julienrbrt julienrbrt enabled auto-merge (squash) July 9, 2025 08:42
@julienrbrt julienrbrt merged commit 3b98730 into release/v28.x.y Jul 9, 2025
41 of 44 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v28.x.y/pr-4744 branch July 9, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

Assignees

@julienrbrt julienrbrt

Labels
component:ci CI/CD workflow and automated jobs. component:cmd component:configs component:docs Documentation additions or improvements. component:packages component:templates type:internal type:services Service-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@julienrbrt