Skip to content

Conversation

julienrbrt
Copy link
Member

Closes: #4688

@julienrbrt julienrbrt requested a review from toschdev as a code owner May 19, 2025 10:00
@julienrbrt julienrbrt enabled auto-merge (squash) May 20, 2025 14:08
Pantani
Pantani previously approved these changes May 21, 2025
Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, It would be nice if these errors were passed to the top level instead of being handled internally within the module with panic. Was the error return removed from the SDK?

@julienrbrt julienrbrt merged commit df47625 into main May 21, 2025
43 checks passed
@julienrbrt julienrbrt deleted the julien/tpl-genesis branch May 21, 2025 18:21
@julienrbrt
Copy link
Member Author

IMHO, It would be nice if these errors were passed to the top level instead of being handled internally within the module with panic. Was the error return removed from the SDK?

Yeah, this is a regression from the SDK apis. v0.52 had many improvements in core v1 that got reverted 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FIX: v29.0.0-rc1 AppModule generated code does not correctly implement the HasGenesis interface
2 participants