refactor: remove xgenny embed walker #4677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mbedwalker # Conflicts: # ignite/cmd/chain.go # ignite/services/chain/proto.go
julienrbrt
reviewed
May 23, 2025
There was a problem hiding this comment.
what was the rationale of removing the app path everywhere? will it look only for relative directory? what if you use ignite from outside the directory, using the --path flag (not in front of my laptop, i'll try locally what i mean to see if that still works)
…mbedwalker # Conflicts: # ignite/services/scaffolder/init.go # ignite/templates/ibc/packet.go # ignite/templates/message/message.go # ignite/templates/testutil/register.go # ignite/templates/typed/typed.go
We are not using the app path, which was only for the |
julienrbrt
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3393