Skip to content

refactor(templates): harden IsSlice #4667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2025
Merged

refactor(templates): harden IsSlice #4667

merged 3 commits into from
May 9, 2025

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented May 8, 2025 •
edited
Loading

IsSlice was doing the shortcut of NonIndexable = Slices.
While 99% true, this isn't the case for Coin.

  • check for all supported data types if there're not other mismatch.

@julienrbrt julienrbrt marked this pull request as ready for review May 8, 2025 23:47
@Pantani Pantani merged commit 3b4229b into main May 9, 2025
44 checks passed
@Pantani Pantani deleted the julien/fix-slices branch May 9, 2025 04:03
@julienrbrt julienrbrt mentioned this pull request May 30, 2025
Merged
@BrewTestBot BrewTestBot mentioned this pull request May 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pantani Pantani Pantani approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3

@toschdev toschdev Awaiting requested review from toschdev

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi

Assignees

@julienrbrt julienrbrt

Labels
component:ci CI/CD workflow and automated jobs. component:configs component:templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienrbrt @Pantani