Skip to content

fix: indentation for params scaffolded into a struct #4658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 8, 2025
Merged

fix: indentation for params scaffolded into a struct #4658

merged 16 commits into from
May 8, 2025

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented May 6, 2025 •
edited
Loading

use the xast package to add params into a struct inside a function will add a new param in the same line of the last parameter, causing a bad indetation. This PR fix this issue add a new parameter for each new line

eg:

	k := Keeper{
		storeService: storeService,
		cdc:          cdc,
		addressCodec: addressCodec,
		authority:    authority,

		Params: collections.NewItem(sb, types.ParamsKey, "params", codec.CollValue[types.Params](cdc)), TestListSeq: collections.NewSequence(sb, types.TestListCountKey, "testListSequence"), TestList: collections.NewMap(sb, types.TestListKey, "testList", collections.Uint64Key, codec.CollValue[types.TestList](cdc)), TestMap: collections.NewMap(sb, types.TestMapKey, "testMap", collections.StringKey, codec.CollValue[types.TestMap](cdc)), TestSingle: collections.NewItem(sb, types.TestSingleKey, "testSingle", codec.CollValue[types.TestSingle](cdc)),
	}

Expected:

	k := Keeper{
		storeService: storeService,
		cdc:          cdc,
		addressCodec: addressCodec,
		authority:    authority,

		Params:   collections.NewItem(sb, types.ParamsKey, "params", codec.CollValue[types.Params](cdc)),
		TestList: collections.NewMap(sb, types.TestListKey, "testList", collections.Uint64Key, codec.CollValue[types.TestList](cdc)), TestListSeq: collections.NewSequence(sb, types.TestListCountKey, "testListSequence"),
		TestMap:    collections.NewMap(sb, types.TestMapKey, "testMap", collections.StringKey, codec.CollValue[types.TestMap](cdc)),
		TestSingle: collections.NewItem(sb, types.TestSingleKey, "testSingle", codec.CollValue[types.TestSingle](cdc)),
	}

@Pantani Pantani self-assigned this May 6, 2025
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs component:packages labels May 6, 2025
@Pantani Pantani requested review from salmad3 and toschdev as code owners May 6, 2025 16:42
@Pantani Pantani marked this pull request as draft May 6, 2025 16:49
@Pantani Pantani marked this pull request as ready for review May 7, 2025 03:49
@julienrbrt
Copy link
Member

julienrbrt commented May 7, 2025 •
edited
Loading

Looks like it fails before of a misplaced comment:
image
https://github.com/ignite/cli/actions/runs/14886377325/job/41806955815?pr=4658

@Pantani Pantani force-pushed the fix/scaffold-struct-param branch from 977d355 to be57b58 Compare May 8, 2025 03:43
@julienrbrt julienrbrt enabled auto-merge (squash) May 8, 2025 08:05
@julienrbrt julienrbrt merged commit 62c0ab9 into main May 8, 2025
43 checks passed
@julienrbrt julienrbrt deleted the fix/scaffold-struct-param branch May 8, 2025 08:16
@julienrbrt julienrbrt mentioned this pull request May 30, 2025
Merged
@BrewTestBot BrewTestBot mentioned this pull request May 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi

@salmad3 salmad3 Awaiting requested review from salmad3

@toschdev toschdev Awaiting requested review from toschdev

Assignees

@Pantani Pantani

Labels
component:ci CI/CD workflow and automated jobs. component:configs component:packages component:templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pantani @julienrbrt