Skip to content

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt marked this pull request as ready for review May 7, 2025 10:39
@Pantani
Copy link
Collaborator

Pantani commented May 7, 2025

The params keeper was deprecated in this version, should we remove it here?

ParamsKeeper paramskeeper.Keeper

@Pantani
Copy link
Collaborator

Pantani commented May 7, 2025

The params keeper was deprecated in this version, should we remove it here?

ParamsKeeper paramskeeper.Keeper

Hmm, maybe another PR, the legacy init we use in IBC is using the params keeper now

@julienrbrt
Copy link
Member Author

The params keeper was deprecated in this version, should we remove it here?

ParamsKeeper paramskeeper.Keeper

Hmm, maybe another PR, the legacy init we use in IBC is using the params keeper now

Yes, IBC simapp still used it: https://github.com/cosmos/ibc-go/blob/main/simapp/app.go#L870-L883 so that's why i kept it.

@julienrbrt julienrbrt merged commit 1b7f19f into main May 7, 2025
43 checks passed
@julienrbrt julienrbrt deleted the julien/053 branch May 7, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosmos SDK v0.53 upgrade
2 participants