Skip to content

fix: xast misplacing comments #4656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 6, 2025
Merged

fix: xast misplacing comments #4656

merged 3 commits into from
May 6, 2025

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented May 4, 2025

close #4582

@Pantani Pantani self-assigned this May 4, 2025
@Pantani Pantani requested review from salmad3 and toschdev as code owners May 4, 2025 14:31
julienrbrt
julienrbrt approved these changes May 5, 2025
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. I like the import functions simplification as well

@Pantani Pantani merged commit 67a4b9b into main May 6, 2025
43 checks passed
@Pantani Pantani deleted the fix/xast-comments branch May 6, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi

@salmad3 salmad3 Awaiting requested review from salmad3

@toschdev toschdev Awaiting requested review from toschdev

Assignees

@Pantani Pantani

Labels
component:ci CI/CD workflow and automated jobs. component:configs component:packages component:templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FIX: Ast is misplacing comments
2 participants
@Pantani @julienrbrt