Skip to content

feat(cosmosfaucet): loosen faucet check when indexer disabled (backport #4633) #4637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 18, 2025
Merged

feat(cosmosfaucet): loosen faucet check when indexer disabled (backport #4633) #4637

merged 4 commits into from
Apr 18, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 18, 2025

Closes: #4528

Ignite CLI will now check the user config.yml for an indexer override and skip the checks accordignly:

validators:
  - name: alice
    bonded: 100000000stake
    config:
      tx_index:
        indexer: "null"
```<hr>This is an automatic backport of pull request #4633 done by [Mergify](https://mergify.com).

@julienrbrt @mergify
feat(cosmosfaucet): loosen faucet check when indexer disabled (#4633)
13bea6f 
(cherry picked from commit 8e76c5f)

# Conflicts:
#	ignite/services/chain/faucet.go
@mergify mergify bot requested a review from ilgooz as a code owner April 18, 2025 05:48
@mergify mergify bot added the conflicts label Apr 18, 2025
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Apr 18, 2025

Cherry-pick of 8e76c5f has failed:

On branch mergify/bp/release/v28.x.y/pr-4633
Your branch is up to date with 'origin/release/v28.x.y'.

You are currently cherry-picking commit 8e76c5f2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   changelog.md
	modified:   ignite/pkg/cosmosfaucet/cosmosfaucet.go
	modified:   ignite/pkg/cosmosfaucet/transfer.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ignite/services/chain/faucet.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested review from Pantani and julienrbrt as code owners April 18, 2025 05:48
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs type:services Service-related issues. component:packages labels Apr 18, 2025
julienrbrt
julienrbrt previously approved these changes Apr 18, 2025
View reviewed changes
@julienrbrt julienrbrt merged commit a1419ce into release/v28.x.y Apr 18, 2025
38 of 41 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v28.x.y/pr-4633 branch April 18, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

Assignees
No one assigned
Labels
component:ci CI/CD workflow and automated jobs. component:configs component:packages type:services Service-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@julienrbrt