refactor: add default openapi.yml when skipping proto gen
#4596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3aaf432 to
2175512
Compare
julienrbrt
requested changes
Mar 25, 2025
There was a problem hiding this comment.
Do you have steps to reproduce?
Using --no-module generates an openapi.yml to me:
{
"id": "gm",
"consumes": ["application/json"],
"produces": ["application/json"],
"swagger": "2.0",
"info":
{
"description": "Chain gm REST API",
"title": "HTTP API Console",
"contact": { "name": "gm" },
"version": "version not set",
},
"paths": {},
"definitions":
{
"google.protobuf.Any":
{
"type": "object",
"properties": { "@type": { "type": "string" } },
"additionalProperties": {},
},
"google.rpc.Status":
{
"type": "object",
"properties":
{
"code": { "type": "integer", "format": "int32" },
"details":
{
"type": "array",
"items":
{
"type": "object",
"$ref": "#/definitions/google.protobuf.Any",
},
},
"message": { "type": "string" },
},
},
},
}
|
I see it failing in the two other PRs you have in CI, but when i try locally from HEAD of main, or run |
weird, it is falling locally here as well. try to run the |
julienrbrt
reviewed
Mar 26, 2025
julienrbrt
reviewed
Mar 26, 2025
openapi.yml static docopenapi.yml when skipping proto gen
julienrbrt
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you scaffold a chain without a module, the
openapi.ymlfile will not be generated, and the chain will be broken because this file is embedded into the codecli/ignite/templates/app/files/docs/docs.go.plush
Lines 17 to 18 in 29b4442