Skip to content

fix: add proto version to query path #4577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 18, 2025
Merged

fix: add proto version to query path #4577

merged 7 commits into from
Mar 18, 2025

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Mar 17, 2025 •
edited
Loading

  • Add proto version to the proto querries path;
  • Fix test permission;
  • Pass the clientCtx.CmdContext instead of context.Background() to the RegisterQueryHandlerClient;
  • Move the sequence collection name to camel case;

@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:templates component:configs type:services Service-related issues. labels Mar 17, 2025
@Pantani Pantani changed the title fix: proversion queries fix: add proto version to queries Mar 17, 2025
@Pantani Pantani marked this pull request as ready for review March 17, 2025 23:23
@Pantani Pantani changed the title fix: add proto version to queries fix: add proto version to query path Mar 17, 2025
julienrbrt
julienrbrt reviewed Mar 17, 2025
View reviewed changes
julienrbrt
julienrbrt previously approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! great catch

@Pantani Pantani merged commit a682b3b into main Mar 18, 2025
40 of 45 checks passed
@Pantani Pantani deleted the fix/cli-queries branch March 18, 2025 01:26
@julienrbrt julienrbrt mentioned this pull request May 30, 2025
Merged
@BrewTestBot BrewTestBot mentioned this pull request May 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi

@salmad3 salmad3 Awaiting requested review from salmad3

@toschdev toschdev Awaiting requested review from toschdev

Assignees

@Pantani Pantani

Labels
component:ci CI/CD workflow and automated jobs. component:configs component:templates type:services Service-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pantani @julienrbrt