Skip to content

chore: enable copyloopvar linter #4160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jun 18, 2024
Merged

chore: enable copyloopvar linter #4160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
b64a150
copyloopvar
faddat May 19, 2024
fea5c84
enable copyloopvar linter
faddat May 19, 2024
8520870
Update types_command_test.go
faddat May 19, 2024
8b9500a
Merge branch 'main' into faddat/copyloopvar2
faddat May 19, 2024
8c874ea
bump linter
faddat May 19, 2024
f1741c1
Merge branch 'faddat/copyloopvar2' of https://github.com/faddat/starp…
faddat May 19, 2024
f021fe0
update linter settings
faddat May 19, 2024
f386769
cleanup
faddat May 19, 2024
bb4686e
revert mistaken changes
faddat May 19, 2024
5c6c6d5
Merge branch 'main' into faddat/copyloopvar2
faddat May 19, 2024
9af1bf9
Merge remote-tracking branch 'origin/main' into faddat/copyloopvar2
faddat May 21, 2024
b504975
Merge branch 'main' into faddat/copyloopvar2
faddat May 21, 2024
e8c2740
Merge branch 'main' into faddat/copyloopvar2
Pantani May 24, 2024
3666e09
Merge branch 'main' into faddat/copyloopvar2
Pantani May 28, 2024
d2a9c45
Merge branch 'main' into faddat/copyloopvar2
Pantani May 28, 2024
83980e7
Merge branch 'main' into faddat/copyloopvar2
Pantani May 29, 2024
5d46d94
Merge branch 'main' into faddat/copyloopvar2
Pantani Jun 13, 2024
41e3960
rollback chain/init.go changes
Pantani Jun 13, 2024
3d8b580
Merge branch 'main' into faddat/copyloopvar2
julienrbrt Jun 18, 2024
d40ded9
Merge branch 'main' into faddat/copyloopvar2
julienrbrt Jun 18, 2024
901f8f0
Merge branch 'main' into faddat/copyloopvar2
julienrbrt Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ linters:
disable-all: true
enable:
- bodyclose
- copyloopvar
- decorder
- depguard
- dogsled
Expand Down
6 changes: 3 additions & 3 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@

### Changes


- [#4162](https://github.com/ignite/cli/pull/4162) Enable errcheck linter and fix a bug in the way we test flags
- [#4159](https://github.com/ignite/cli/pull/4159) Enable gci linter
- [#4157](https://github.com/ignite/cli/pull/4157) Upgrade golang to 1.22
- [#4094](https://github.com/ignite/cli/pull/4094) Scaffolding a multi-index map using `ignite s map foo bar baz --index foobar,foobaz` is no longer supported. Use one index instead of use `collections.IndexedMap`.
- [#4058](https://github.com/ignite/cli/pull/4058) Simplify scaffolded modules by including `ValidateBasic()` logic in message handler.
Expand All @@ -43,6 +40,9 @@
- [#4167](https://github.com/ignite/cli/pull/4167) Scaffold `int64` instead of `int32` when a field type is `int`
- [#4168](https://github.com/ignite/cli/pull/4168) Bump IBC to `v8.3.1`
- [#4178](https://github.com/ignite/cli/pull/4178) Bump cosmos-sdk to `v0.50.7`
- [#4159](https://github.com/ignite/cli/pull/4159) Enable gci linter
- [#4160](https://github.com/ignite/cli/pull/4160) Enable copyloopvar linter
- [#4162](https://github.com/ignite/cli/pull/4162) Enable errcheck linter

### Fixes

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module github.com/ignite/cli/v29

go 1.22

toolchain go1.22.2
toolchain go1.22.3

replace (
github.com/99designs/keyring => github.com/cosmos/keyring v1.2.0
Expand Down
2 changes: 1 addition & 1 deletion ignite/cmd/chain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ func configMigrationPreRunHandler(cmd *cobra.Command, session *cliui.Session, ap
return err
}

if err := os.WriteFile(cfgPath, buf.Bytes(), 0o755); err != nil {
if err := os.WriteFile(cfgPath, buf.Bytes(), 0o600); err != nil {
return errors.Errorf("config file migration failed: %w", err)
}
}
Expand Down
1 change: 0 additions & 1 deletion ignite/pkg/cmdrunner/cmdrunner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ func (r *Runner) Run(ctx context.Context, steps ...*step.Step) error {
step.Exec.Command,
strings.Join(step.Exec.Args, " "))
}
step := step
if err := ctx.Err(); err != nil {
return err
}
Expand Down
2 changes: 0 additions & 2 deletions ignite/pkg/cosmosgen/generate_composables.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,6 @@ func (g *composablesGenerator) generateComposableTemplates(p generatePayload) er
gg := &errgroup.Group{}

for _, m := range p.Modules {
m := m

gg.Go(func() error {
return g.generateComposableTemplate(m, p)
})
Expand Down
2 changes: 0 additions & 2 deletions ignite/pkg/cosmosgen/generate_typescript.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,6 @@ func (g *tsGenerator) generateModuleTemplates(ctx context.Context) error {
dirCache := cache.New[[]byte](g.g.cacheStorage, dirchangeCacheNamespace)
add := func(sourcePath string, modules []module.Module) {
for _, m := range modules {
m := m

gg.Go(func() error {
cacheKey := m.Pkg.Path
paths := []string{m.Pkg.Path, g.g.opts.jsOut(m)}
Expand Down
1 change: 0 additions & 1 deletion ignite/version/version_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ func TestAssertSupportedCosmosSDKVersion(t *testing.T) {
}

for _, tc := range testCases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
err := version.AssertSupportedCosmosSDKVersion(tc.version)
if tc.errMsg == "" {
Expand Down