chore: lint tests #4156
Merged
chore: lint tests #4156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
reviewed
May 19, 2024
|
gci is that linter, and it is configured in its standard way. We could also configure it to group like how was done in ibc, or sdk. Ah, yeah I think I know exactly what you're looking for after checking the changeset.... moment |
|
@julienrbrt I think that checking errors found a bug. To make this easier to review, I'll separate the gci changes. |
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
|
@Pantani - actually that makes sense! Let me fix that issue with the import ordering. Thanks for pointing it out. |
|
recommend merging this first: |
|
great!! thanks for contributing @faddat |
|
@faddat, there are some merge conflicts. I think the problem is because the cleanup method into the |
# Conflicts: # ignite/internal/plugin/testdata/execute_fail/go.mod # ignite/internal/plugin/testdata/execute_ok/go.mod # ignite/services/chain/init.go # integration/node/cmd_query_bank_test.go # integration/node/cmd_tx_bank_send_test.go # integration/plugin/testdata/example-plugin/go.mod
Pantani
previously approved these changes
Jun 26, 2024
julienrbrt
reviewed
Jun 28, 2024
julienrbrt
reviewed
Jun 28, 2024
Pantani
approved these changes
Jun 28, 2024
julienrbrt
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint tests so that the codebase is consistently linted