Skip to content

Support for Go 1.25 #4752

@stefanb

Description

@stefanb

👋 During the testing of Go 1.25rc1 in

it was noted that the build of Ignite CLI fails with:

# github.com/bytedance/sonic/internal/rt
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/bytedance/sonic@v1.13.2/internal/rt/stubs.go:33:22: undefined: GoMapIterator
/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/bytedance/sonic@v1.13.2/internal/rt/stubs.go:36:54: undefined: GoMapIterator

The upstream module github.com/bytedance/sonic already has a fix

merged and available in the v1.14.0-rc1 prerelease. Initial testing shows that updating that module fixes the build.

Please

  • go get -u github.com/bytedance/sonic@v1.14.0-rc1
  • run the CI tests to make sure nothing is broken
  • test with Go 1.25rc1 and fix any other changes needed and/or report bugs upstream
  • wait until 1.14.0 or later release is available
  • update the github.com/bytedance/sonic module (eg via go get -u github.com/bytedance/sonic@latest)
  • create a release

Please note that Go 1.25rc2 is expected on Tuesday and final is scheduled for August. It would be ideal if you make a release with Go 1.25 support before that or at least immediately after the release.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions